Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][responsiveFontSizes] Handled undefined variants #42412

Merged
merged 1 commit into from
May 27, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented May 27, 2024

We ask users to disable typography variants by setting them to undefined but this was not handled in the runtime code of responsiveFontSizes.
This change fixes that.

Fixes #42252

@brijeshb42 brijeshb42 added bug 🐛 Something doesn't work component: Typography The React component. package: material-ui Specific to @mui/material labels May 27, 2024
@brijeshb42 brijeshb42 requested review from DiegoAndai and a team May 27, 2024 05:23
@mui-bot
Copy link

mui-bot commented May 27, 2024

Netlify deploy preview

https://deploy-preview-42412--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7198d75

@brijeshb42 brijeshb42 enabled auto-merge (squash) May 27, 2024 07:18
@brijeshb42 brijeshb42 closed this May 27, 2024
auto-merge was automatically disabled May 27, 2024 11:49

Pull request was closed

@brijeshb42 brijeshb42 reopened this May 27, 2024
@brijeshb42 brijeshb42 added the needs cherry-pick The PR should be cherry-picked to master after merge label May 27, 2024
@brijeshb42 brijeshb42 merged commit 648aeab into mui:next May 27, 2024
19 checks passed
@brijeshb42 brijeshb42 deleted the fix/response-font-sizes branch May 27, 2024 13:27
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Typography The React component. needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

responsiveFontSizes crashes when one of the variants is disabled
3 participants