[material-ui][Popover] migrate useSlotProps to useSlot #42369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42369--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
commented
May 24, 2024
| @@ -74,7 +74,6 @@ describe('<Popover />', () => { | |||
| 'themeStyleOverrides', // portal, can't determine the root | |||
| 'themeVariants', | |||
| 'reactTestRenderer', // react-transition-group issue | |||
| 'slotPropsCallback', // not supported yet | |||
There was a problem hiding this comment.
proof for slotProps callback is working
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42310
since there were no deprecated props, i didn't added any guides for codemod , deprecation
Once #42358 is merged, i'm expecting argos to work fine