-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Popper] Deprecate components and componentProps props for v6 #42111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
ChronicusUA
force-pushed
the
feat/41279-Update-Popper
branch
from
May 3, 2024 15:04
f7de413
to
32a1ceb
Compare
zannager
added
component: Popper
The React component. See <Popup> for the latest version.
package: material-ui
Specific to @mui/material
labels
May 3, 2024
17 tasks
DiegoAndai
reviewed
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChronicusUA, thanks for working on this!
It it looking good, I just have a couple of small corrections and a question about the EOL issue.
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
packages/mui-codemod/src/deprecations/popper-props/popper-props.js
Outdated
Show resolved
Hide resolved
ChronicusUA
force-pushed
the
feat/41279-Update-Popper
branch
from
May 6, 2024 12:01
95f4c17
to
795aabd
Compare
PR is updated |
DiegoAndai
approved these changes
May 24, 2024
Thanks @ChronicusUA! |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: Popper
The React component. See <Popup> for the latest version.
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41279
Deprecate components and componentsProps props for Popper component.