-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigment-css] Fix props forwarding #41688
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d24e9d1
wip
siriwatknp cc48f24
Merge branch 'next' of https://github.com/mui/material-ui into pigmen…
siriwatknp 9d32ab0
add is-prop-valid and test cases
siriwatknp 310e224
add "no prop filtering on non string tags"
siriwatknp adab95e
add styled variants test
siriwatknp 3360308
fix styled filtering props with tests
siriwatknp b99bca8
Merge branch 'next' of https://github.com/mui/material-ui into pigmen…
siriwatknp a55f198
add tests for classes prop
siriwatknp b495af6
add local capitalize
siriwatknp f9433d1
remove capitalize
siriwatknp 785c329
trigger build
siriwatknp bff1a79
run pnpm dedupe
siriwatknp 2fffefa
Merge branch 'next' of https://github.com/mui/material-ui into pigmen…
siriwatknp 0e1e900
fix lint
siriwatknp ff21a5b
fix typedef
siriwatknp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/pigment-css-react/tests/styled/fixtures/styled-variants.input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { styled } from '@pigment-css/react'; | ||
|
||
const Button = styled('button')({ | ||
variants: [ | ||
{ | ||
props: { color: 'primary' }, | ||
style: { | ||
color: 'tomato', | ||
}, | ||
}, | ||
{ | ||
props: ({ ownerState }) => ownerState.color === 'secondary', | ||
style: { | ||
color: 'salmon', | ||
}, | ||
}, | ||
], | ||
}); |
6 changes: 6 additions & 0 deletions
6
packages/pigment-css-react/tests/styled/fixtures/styled-variants.output.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.b1prasel-1 { | ||
color: tomato; | ||
} | ||
.b1prasel-2 { | ||
color: salmon; | ||
} |
17 changes: 17 additions & 0 deletions
17
packages/pigment-css-react/tests/styled/fixtures/styled-variants.output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { styled as _styled } from '@pigment-css/react'; | ||
import _theme from '@pigment-css/react/theme'; | ||
const Button = /*#__PURE__*/ _styled('button')({ | ||
classes: ['b1prasel'], | ||
variants: [ | ||
{ | ||
props: { | ||
color: 'primary', | ||
}, | ||
className: 'b1prasel-1', | ||
}, | ||
{ | ||
props: ({ ownerState }) => ownerState.color === 'secondary', | ||
className: 'b1prasel-2', | ||
}, | ||
], | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is comparatively faster than
Object.keys
since optimizing thisstyled
call is the most important part as it'll be called a lot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, it's the same logic as emotion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styled-component also do the same.