[pigment-css][demo] Improve sx prop support #41589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41589--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
pigment/demo-sx
branch
2 times, most recently
from
8bbfe5a
to
0f0e553
Compare
siriwatknp
reviewed
Mar 22, 2024
Comment on lines
+22
to
+28
| className={css` | ||
| width: 100vw; | ||
| height: 100vh; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| `} |
There was a problem hiding this comment.
why not sx? if it's for testing, it's fine for me.
There was a problem hiding this comment.
Mainly because I was copy pasting and sx only supports object syntax.
siriwatknp
reviewed
Mar 22, 2024
| @@ -33,7 +33,6 @@ | |||
| "@wyw-in-js/shared": "^0.5.0", | |||
| "@wyw-in-js/transform": "^0.5.0", | |||
| "babel-plugin-define-var": "^0.1.0", | |||
| "babel-plugin-transform-react-remove-prop-types": "^0.4.24", | |||
There was a problem hiding this comment.
I'll move the define-var to pigment repo later.
brijeshb42
force-pushed
the
pigment/demo-sx
branch
from
905e90f
to
40b4988
Compare
github-actions
bot
added
PR: out-of-date
brijeshb42
force-pushed
the
pigment/demo-sx
branch
4 times, most recently
from
397a355
to
9a1e6bd
Compare
github-actions
bot
added
the
PR: out-of-date
transformation. It can now handle dynamic keys in the object where the keys are defined using file scoped or theme variables.
brijeshb42
force-pushed
the
pigment/demo-sx
branch
from
9a1e6bd
to
476a987
Compare
github-actions
bot
removed
the
PR: out-of-date
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 29, 2024
tejasparkar
pushed a commit
to tejasparkar/material-ui
that referenced
this pull request
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are now able to build both vite and next.js demo apps without disabling sx prop transpilation. There are two commits: