Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] move feedback to ESM #41381

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Mar 6, 2024

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Mar 6, 2024
@mui-bot
Copy link

mui-bot commented Mar 6, 2024

Netlify deploy preview

https://deploy-preview-41381--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7bfe01e

@alexfauquette alexfauquette marked this pull request as ready for review March 6, 2024 10:56
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Approving assuming the typescript ci workflow will pass

message,
actions: [{ value }],
} = body;
} = body as BlockAction<ButtonAction>;
Copy link
Member

@Janpot Janpot Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These casts can be avoided when creating the action as

app.action<BlockAction<ButtonAction>>(...

@alexfauquette alexfauquette merged commit 33c8b91 into mui:master Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants