Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigment-css] Handle more scenarios while transforming sx prop #41372

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[pigment-css] Handle more scenarios while transforming sx prop #41372

merged 2 commits into from
Mar 8, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Mar 5, 2024 •
edited
Loading

This now provides the ability to have simple expressions like conditional and logical expressions in the sx prop code.
See added tests for the scenarios handled.

TODOs :

  • Specifically handle conditional spreads within the css object
  • Handle theme method or theme object spreads

@brijeshb42 brijeshb42 requested review from siriwatknp and a team March 5, 2024 13:47
@brijeshb42 brijeshb42 added the package: pigment-css Specific to @pigment-css/* label Mar 5, 2024
@mui-bot
Copy link

mui-bot commented Mar 5, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41372--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a318313

@brijeshb42 brijeshb42 force-pushed the pigment/better-sx branch 2 times, most recently from 49af547 to 54d319b Compare March 5, 2024 14:11
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 5, 2024
@brijeshb42 brijeshb42 changed the title [pigment] Handle more scenarios while transforming [pigment] Handle more scenarios while transforming sx prop Mar 5, 2024
@brijeshb42 brijeshb42 force-pushed the pigment/better-sx branch 4 times, most recently from 8c08049 to a7f9012 Compare March 6, 2024 06:59
@brijeshb42 brijeshb42 requested review from siriwatknp and removed request for siriwatknp March 6, 2024 07:01
@brijeshb42 brijeshb42 force-pushed the pigment/better-sx branch 3 times, most recently from ac457b2 to a1aa0a5 Compare March 7, 2024 09:41
siriwatknp
siriwatknp approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 8, 2024
@brijeshb42
[pigment] Handle more scenarios while transforming
8f3c398 
sx prop. This now provides the ability to have simple
expressions like conditional and logical expressions
in the sx prop code.
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 8, 2024
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@brijeshb42 @mnajdova
[pigment] Handle more scenarios while transforming sx prop (mui#41372)
71939dd
@oliviertassinari oliviertassinari changed the title [pigment] Handle more scenarios while transforming sx prop [pigment-css] Handle more scenarios while transforming sx prop Mar 10, 2024
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@amylank22 amylank22 mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
@mxiloyannis mxiloyannis mentioned this pull request May 21, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request May 22, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

@brijeshb42 brijeshb42

Labels
package: pigment-css Specific to @pigment-css/*
Projects
Pigment CSS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brijeshb42 @mui-bot @siriwatknp