-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Divider] Convert to support CSS extraction #41366
Conversation
Netlify deploy previewhttps://deploy-preview-41366--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
@siriwatknp ran following commands to render demos locally but facing following error
|
props: ({ ownerState }) => | ||
ownerState.variant === 'middle' && ownerState.orientation === 'horizontal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props: ({ ownerState }) => | |
ownerState.variant === 'middle' && ownerState.orientation === 'horizontal', | |
props: { variant: 'middle', orientation: 'horizontal' }, |
I think object comparison should be used if possible. It's shorter and more readable.
x the others.
}, | ||
}, | ||
{ | ||
props: ({ ownerState }) => ownerState.children, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props: ({ ownerState }) => ownerState.children, | |
props: ({ ownerState }) => !!ownerState.children, |
should explicitly return boolean
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: in v7, this could be replaced with pseudo :not(:empty)
'&::before, &::after': { | ||
flexDirection: 'column', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sai6855 flexDirection
was not the inside psuedo selector, could you recheck if this is the correct change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps sorry, fixed in this commit 0b39bba
I encounter an error after running |
…e-divider-pigment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
part of #41273
preview: https://deploy-preview-41366--material-ui.netlify.app/material-ui/react-divider