Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Badge] Deprecate components and componentProps props for v6 #41364

Closed
wants to merge 12 commits into from
Closed

[material-ui][Badge] Deprecate components and componentProps props for v6 #41364

wants to merge 12 commits into from

Conversation

skmanoj322
Copy link
Contributor

part of #41279

@DiegoAndai I have reffered to Slider please tell if there is any correction to be made.

looking forward to this pr to merge as this is my first pr in open source.

@mui-bot
Copy link

mui-bot commented Mar 5, 2024

@zannager zannager added the component: badge This is the name of the generic UI component, not the React module! label Mar 5, 2024
@zannager zannager requested a review from DiegoAndai March 5, 2024 15:20
@skmanoj322 skmanoj322 closed this Mar 7, 2024
@skmanoj322 skmanoj322 deleted the manoj/badge-v6-deprecations branch March 7, 2024 15:08
@DiegoAndai
Copy link
Member

Hey @skmanoj322, sorry for the late reply. I was about to review this. Was there a particular reason you closed it?

@skmanoj322
Copy link
Contributor Author

skmanoj322 commented Mar 7, 2024

I think I have deleted that from my forked branch. sorry for trouble I will create on more pr

@skmanoj322 skmanoj322 restored the manoj/badge-v6-deprecations branch March 7, 2024 18:22
@skmanoj322
Copy link
Contributor Author

#41399 is the new pr. again sorry for the errors

@DiegoAndai
Copy link
Member

@skmanoj322 no problem! I'll review the new one.

@skmanoj322
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants