[core] Add a script to build all packages #40631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40631--material-ui.netlify.app/ Bundle size report |
brijeshb42
approved these changes
Jan 16, 2024
Which one ( |
|
It would be safer to build all projects (so to change the previous behavior). This way we'll ensure that all projects are in a good state all the time. |
|
@brijeshb42, would you mind taking a look at the failing zero-runtime-next-app build? |
|
@michaldudak Yeah. I also just encountered it and am looking into the reason. |
michaldudak
force-pushed
the
build-scripts
branch
from
9ab1ea5
to
0640c89
Compare
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
build-scripts
branch
from
0640c89
to
2e50d8f
Compare
github-actions
bot
removed
the
PR: out-of-date
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
buildscript builds only the public packages (@mui/*).This PR adds a new one,
build:allto build all the workspace packages.Alternatively, I'm also considering using
buildto build all packages and introducingbuild:publicfor public ones (instead of introducingbuild:all). This way, runningbuildas usual will verify if the whole repo is in a buildable state.