[docs-infra] Fix anchor links in API pages #40450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-40450--material-ui.netlify.app/ Bundle size report |
oliviertassinari
commented
Jan 7, 2024
| targetName={pageContent.name} | ||
| componentName={pageContent.name} |
There was a problem hiding this comment.
I went with a solution that minimize the number of types that we manipulate. It seems simpler to kebab case convert at the very end.
alexfauquette
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
I noticed classes did not have the wrapper because they did not have the scrollMarginTop property. I'm adding a commit to fix that.
The scroll is not well aligned for the first two row, because the scroll margin top is blocked by the overflow hidden
I tried different config but nothing worked on chrome, so I dropped the topic
alexfauquette
force-pushed
the
api-fix-classname
branch
from
fa1ce87
to
713b4c9
Compare
Oh wow, I didn't know this. Another reason why #40476 then 😄 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Co-authored-by: alexandre <alex.fauquette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40395 (comment)
Before: https://deploy-preview-40395--material-ui.netlify.app/base-ui/react-menu/components-api/#menu-item-classes-focusVisible
After: https://deploy-preview-40450--material-ui.netlify.app/base-ui/react-menu/components-api/#menu-item-classes-focusVisible