-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lab][Masonry] Ability to sort elements from left to right #39904
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7d06304
add sequential masonry
GSS-Rishi 4b70da5
Add tests and fix linter issues
GSS-Rishi 788effb
Update sequential tests
GSS-Rishi e03cb44
use height for testing
Rishi556 144fefb
save
GSS-Rishi b16cea5
Fix tests
GSS-Rishi f449700
move handleResize out of effect
GSS-Rishi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import * as React from 'react'; | ||
import Box from '@mui/material/Box'; | ||
import { styled } from '@mui/material/styles'; | ||
import Paper from '@mui/material/Paper'; | ||
import Masonry from '@mui/lab/Masonry'; | ||
|
||
const heights = [150, 30, 90, 70, 110, 150, 130, 80, 50, 90, 100, 150, 30, 50, 80]; | ||
|
||
const Item = styled(Paper)(({ theme }) => ({ | ||
backgroundColor: theme.palette.mode === 'dark' ? '#1A2027' : '#fff', | ||
...theme.typography.body2, | ||
padding: theme.spacing(0.5), | ||
textAlign: 'center', | ||
color: theme.palette.text.secondary, | ||
})); | ||
|
||
export default function Sequential() { | ||
return ( | ||
<Box sx={{ width: 500, minHeight: 393 }}> | ||
<Masonry | ||
columns={4} | ||
spacing={2} | ||
defaultHeight={450} | ||
defaultColumns={4} | ||
defaultSpacing={1} | ||
sequential | ||
> | ||
{heights.map((height, index) => ( | ||
<Item key={index} sx={{ height }}> | ||
{index + 1} | ||
</Item> | ||
))} | ||
</Masonry> | ||
</Box> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import * as React from 'react'; | ||
import Box from '@mui/material/Box'; | ||
import { styled } from '@mui/material/styles'; | ||
import Paper from '@mui/material/Paper'; | ||
import Masonry from '@mui/lab/Masonry'; | ||
|
||
const heights = [150, 30, 90, 70, 110, 150, 130, 80, 50, 90, 100, 150, 30, 50, 80]; | ||
|
||
const Item = styled(Paper)(({ theme }) => ({ | ||
backgroundColor: theme.palette.mode === 'dark' ? '#1A2027' : '#fff', | ||
...theme.typography.body2, | ||
padding: theme.spacing(0.5), | ||
textAlign: 'center', | ||
color: theme.palette.text.secondary, | ||
})); | ||
|
||
export default function Sequential() { | ||
return ( | ||
<Box sx={{ width: 500, minHeight: 393 }}> | ||
<Masonry | ||
columns={4} | ||
spacing={2} | ||
defaultHeight={450} | ||
defaultColumns={4} | ||
defaultSpacing={1} | ||
sequential | ||
> | ||
{heights.map((height, index) => ( | ||
<Item key={index} sx={{ height }}> | ||
{index + 1} | ||
</Item> | ||
))} | ||
</Masonry> | ||
</Box> | ||
); | ||
} |
14 changes: 14 additions & 0 deletions
14
docs/data/material/components/masonry/Sequential.tsx.preview
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
<Masonry | ||
columns={4} | ||
spacing={2} | ||
defaultHeight={450} | ||
defaultColumns={4} | ||
defaultSpacing={1} | ||
sequential | ||
> | ||
{heights.map((height, index) => ( | ||
<Item key={index} sx={{ height }}> | ||
{index + 1} | ||
</Item> | ||
))} | ||
</Masonry> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to move
handleResize
inside the effect? I would rather keep it out, if possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to move it inside because of a eslint rule. I'll see if I can get it working without moving it in and not having to wrap
handleResize
in auseCallback
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good now, let me know what you think.