Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppNavDrawer] Links added to components in the left nav menu #3953

Closed
wants to merge 1 commit into from
Closed

[AppNavDrawer] Links added to components in the left nav menu #3953

wants to merge 1 commit into from

Conversation

aahan96
Copy link
Contributor

@aahan96 aahan96 commented Apr 12, 2016

Now the components on the left nav have got links can be be opened in a new tab with a right click

Closes #2720
Update of #3880

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@aahan96 aahan96 mentioned this pull request Apr 12, 2016
Closed
3 tasks
@nathanmarks nathanmarks mentioned this pull request Apr 21, 2016
Closed
@mbrookes mbrookes added docs Improvements or additions to the documentation PR: Needs Review labels Apr 28, 2016
@MikeCodeur MikeCodeur mentioned this pull request May 5, 2016
Closed
@mbrookes
Copy link
Member

mbrookes commented May 7, 2016

On hold pending #4197

@mbrookes mbrookes added the on hold There is a blocker, we need to wait label May 7, 2016
@nathanmarks nathanmarks added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 18, 2016
@nathanmarks
Copy link
Member

@mbrookes #4197 is merged

@mbrookes mbrookes removed the on hold There is a blocker, we need to wait label May 18, 2016
@mbrookes
Copy link
Member

@aahan96 You can remove linkButton now.

@mbrookes mbrookes added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 18, 2016
@mbrookes
Copy link
Member

Ping @aahan96 😄

@nathanmarks
Copy link
Member

Closing due to lack of movement.

@aahan96 aahan96 mentioned this pull request Jun 23, 2016
Merged
3 tasks
@aahan96
Copy link
Contributor Author

aahan96 commented Jun 23, 2016

@nathanmarks Can you check the new PR, please! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aahan96 @mbrookes @nathanmarks