Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][PoC] Make Joy UI components denser #38418

Closed
wants to merge 22 commits into from

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Aug 10, 2023

Testing some visual changes to the Joy UI default theme, mostly making some components use the sm variant by default

Components set to sm as default:

  • Button
  • IconButton
  • Input
  • FormControl
  • Select
  • ButtonGroup
  • Autocomplete
  • Chip
  • Avatar
  • Switch
  • TextArea
  • ToggleButtonGroup

Learnings

  1. When Avatars, IconButtons or other components are inside the input/select, it ends up with 38px height. I wonder if we should make the md components 38px height than changing variants to sm.
  2. Visually, it only makes sense if all these components have the same height or variants set.

@zanivan zanivan added package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Aug 10, 2023
@siriwatknp
Copy link
Member

I think let's create a density page like Material UI as a first step.

@zanivan
Copy link
Contributor Author

zanivan commented Aug 15, 2023

I think let's create a density page like Material UI as a first step.

I wonder if this shouldn't be on the theme builder page, though. Or it could be a similar page like Material UI, under customization section—resonating with the changes on #38396.

That said, I also think we could make the md denser, then. Maybe 36px or 38px height. What do you think @siriwatknp ?

@siriwatknp
Copy link
Member

I think let's create a density page like Material UI as a first step.

I wonder if this shouldn't be on the theme builder page, though. Or it could be a similar page like Material UI, under customization section—resonating with the changes on #38396.

That said, I also think we could make the md denser, then. Maybe 36px or 38px height. What do you think @siriwatknp ?

For sure, all of the components will need to be changed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants