-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add use-client to custom icons #38132
[core] Add use-client to custom icons #38132
Conversation
Netlify deploy previewhttps://deploy-preview-38132--material-ui.netlify.app/ Bundle size report |
1489568
to
c087c64
Compare
@mj12albert should we push this forward so that we are complete with the RSC compatibility? |
👌will finish this one this week @mnajdova |
363e55e
to
f44a42d
Compare
f44a42d
to
0509f89
Compare
The build output doesn't contain the "use client" directive on the custom icons. You have to run |
@michaldudak Updated ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Fixes #38023
There are handful of custom icons outside of the
/src
directory; alsopackages/mui-icons-material/src/utils/createSvgIcon.js
is not returned byfindComponents
/findHooks
even though it needs'use client'
to work.This PR adds support for:
additionalPaths?: string[]
to handle paths that are outsidepackages/mui-*/src
additionalFiles?: string[]
to handle arbitrary files that are neither components nor hooks