[core] Fix ESM issues with regression tests #37963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37963--material-ui.netlify.app/ Bundle size report |
Janpot
changed the title
This reverts commit a834adc.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Janpot
changed the title
| @@ -32,11 +33,12 @@ module.exports = { | |||
| rules: [ | |||
| { | |||
| test: /\.(js|ts|tsx)$/, | |||
| exclude: /node_modules/, | |||
| exclude: /node_modules|prism\.js/, | |||
There was a problem hiding this comment.
Are we excluding this so that it picks the prism.mjs (ES Module) file?
There was a problem hiding this comment.
It's because @mui/markdown/prism gets imported in several contexts, both ESM and Commonjs. It's a commonjs file but webpack resolves it as ESM and fails to find exports. Ideally we move this to ESM as well, but I don't want to expand the scope of this PR further
ZeeshanTamboli
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37888
It's an alternative to #37888 (comment) in that it stops babel from compiling modules down to commonjs for the regression tests. The goal will be to do this for all targets (
usesEsModules = true).Included in this PR:
react-imask