Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Pass className from BackdropProps #37399

Merged
merged 2 commits into from
May 29, 2023
Merged

[Modal] Pass className from BackdropProps #37399

merged 2 commits into from
May 29, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented May 25, 2023 •
edited
Loading

@hbjORbj hbjORbj changed the title [Drawer][Modal] Pass className from BackdropProps [Drawer][Modal] Pass className from BackdropProps May 25, 2023
@hbjORbj hbjORbj changed the title [Drawer][Modal] Pass className from BackdropProps [Modal] Pass className from BackdropProps May 25, 2023
@hbjORbj hbjORbj self-assigned this May 25, 2023
@hbjORbj hbjORbj added bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! labels May 25, 2023
@mui-bot
Copy link

mui-bot commented May 25, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37399--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 6d8aa67

@hbjORbj hbjORbj mentioned this pull request May 25, 2023
Closed
2 tasks
@zannager zannager requested a review from mnajdova May 25, 2023 13:29
mnajdova
mnajdova reviewed May 29, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add a test for it.

@hbjORbj hbjORbj merged commit 1bede6a into mui:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

@hbjORbj hbjORbj

Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The backdrop className in Drawer/Modal cannot be set via BackdropProps since 5.11.11
3 participants
@hbjORbj @mui-bot @mnajdova