[website] Update X landing page #37387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
website
Netlify deploy previewhttps://deploy-preview-37387--material-ui.netlify.app/ Bundle size report |
2 tasks
amantank
approved these changes
May 31, 2023
amantank
approved these changes
May 31, 2023
This reverts commit f88e59a.
cherniavskii
force-pushed
the
update-x-data-grid-demo
branch
from
5a06870 to
afef398
Compare
cherniavskii
commented
Jun 9, 2023
| @@ -23,7 +23,6 @@ export default function XGridGlobalStyles({ | |||
| // style GridToolbar | |||
| '& .MuiDataGrid-toolbarContainer': { | |||
| padding: theme.spacing(1, 1, 0.5, 1), | |||
| overflow: 'auto', | |||
There was a problem hiding this comment.
Fixes toolbar height
cherniavskii
commented
Jun 9, 2023
| // ------------------------------- | ||
| // table body elements | ||
| '& .MuiDataGrid-viewport': { |
There was a problem hiding this comment.
This class doesn't exist for a long time 😅
cherniavskii
commented
Jun 9, 2023
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import { DataGridPro, GridToolbar } from '@mui/x-data-grid-pro'; | |||
There was a problem hiding this comment.
Changes in this file are mostly related to broken pagination:
pagination-broken.mov
joserodolfofreitas
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Thanks for polishing this, @cherniavskii! Glad to see the demo with these latest improvements.
|
Great, this is much better. If fixed the performance regression Google Search found: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses points 2-4 of #37001 (comment)
Preview: https://deploy-preview-37387--material-ui.netlify.app/x/