[docs-infra] Throw on incorrect internal links #37326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
| @@ -45,7 +45,7 @@ const theme = createTheme({ | |||
| ``` | |||
|
|
|||
| :::warning | |||
| ⚠️ `vars` is a private field for [CSS theme variables](material-ui/experimental-api/css-theme-variables/overview/). It will throw an error if you try to pass a value to it: | |||
| `vars` is a private field for [CSS theme variables](/material-ui/experimental-api/css-theme-variables/overview/). It will throw an error if you try to pass a value to it: | |||
There was a problem hiding this comment.
- I have removed the
⚠️so we can normalize how warning are displayed in the docs - I think that we should stop using the
/overview/pattern,/should be enough for this
1 task
Netlify deploy preview
Bundle size report |
1 task
oliviertassinari
force-pushed
the
fix-link-issues
branch
from
2bfda52 to
89cf4cd
Compare
oliviertassinari
changed the title
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fixes. I have found them looking with Jan into how we can improve Algolia's experience on the docs, especially around the no search results. Its crawler reports issues (301, 404, etc.)
https://crawler.algolia.com/admin/crawlers/739c29c8-99ea-4945-bd27-17a1df391902/monitoring/summary
Docs-infra change: I have added a new logic to break the CI if the link is wrong, this shouldn't go to production.