[Select] [joy] handle long text content #37289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37289--material-ui.netlify.app/ Bundle size report |
zannager
added
component: select
siriwatknp
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37277
Please advise if this is a good way to deal with this issue.
I can hide the scrollbars by just putting
overflow: "hidden"but in order to show the ellipsis I had to first put the content inside a span tag and addwidth: 0to it.This is needed as the button is a flex container due to which I can't directly add
text-overflow: "ellipsis"to it.https://css-tricks.com/flexbox-truncated-text/
Visually everything seems to be working fine.