Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Enable regressions tests & fix regressions #36611

Merged

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 22, 2023

Fixes #36610
If the visual regression tests were enabled would have caught all the issues created after the regression introduced in #33621. I am re-enabling the tests and using a simpler solution to the initial problem proposed by @ZeeshanTamboli

@mnajdova mnajdova added test package: system Specific to @mui/system regression A bug, but worse labels Mar 22, 2023
@mui-bot
Copy link

mui-bot commented Mar 22, 2023

Netlify deploy preview

https://deploy-preview-36611--material-ui.netlify.app/

@material-ui/core: parsed: -0.08% 😍, gzip: -0.08% 😍
@material-ui/lab: parsed: -0.16% 😍, gzip: -0.14% 😍
@material-ui/system: parsed: -0.59% 😍, gzip: -0.51% 😍
@mui/material-next: parsed: -0.31% 😍, gzip: -0.29% 😍
@mui/joy: parsed: -0.11% 😍, gzip: -0.10% 😍

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against aeb376c

@mnajdova mnajdova marked this pull request as ready for review March 22, 2023 12:11
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I couldn't find anything wrong now that might cause an issue.

@mnajdova mnajdova merged commit 2834f98 into mui:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system regression A bug, but worse test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SX-Prop: fontSize with suffix not working since v5.11.13
3 participants