Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Fix bad hint text show condition in edb8ad9c #3657

Merged
merged 1 commit into from
Mar 10, 2016
Merged

[TextField] Fix bad hint text show condition in edb8ad9c #3657

merged 1 commit into from
Mar 10, 2016

Conversation

thomasguillory
Copy link
Contributor

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

The hint text show condition resolves to undefined when floatingLabelFixed property is not passed, which result in the hint text being shown at the same time than the floating label.

@thomasguillory
[TextField] Fix bad hint text show condition in edb8ad9
392d48a 
The hint text show condition resolves to `undefined` when
`floatingLabelFixed` property is not passed, which result in the hint
text being shown at the same time than the floating label.
@alitaheri
Copy link
Member

Ops 😅

alitaheri added a commit that referenced this pull request Mar 10, 2016
@alitaheri
Merge pull request #3657 from Dashlane/fix/floating-label-fixed-undef…
7241149 
…ined

[TextField] Fix bad hint text show condition in edb8ad9
@alitaheri alitaheri merged commit 7241149 into mui:master Mar 10, 2016
This was referenced Aug 19, 2021
Open
Open
Open
Open
This was referenced Sep 12, 2021
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 24, 2021
Open
@maniator maniator mentioned this pull request May 13, 2022
Open
@akashmitra akashmitra mentioned this pull request May 13, 2022
Open
@hzhz hzhz mentioned this pull request May 14, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this pull request May 14, 2022
Open
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Mar 14, 2023
@akashmitra akashmitra mentioned this pull request Jun 20, 2023
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Nov 25, 2023
Open
@akashmitra akashmitra mentioned this pull request Mar 22, 2024
Open
@hzhz hzhz mentioned this pull request Mar 22, 2024
Open
@maniator maniator mentioned this pull request Mar 22, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Mar 22, 2024
Open
@maniator maniator mentioned this pull request May 13, 2024
Open
@hzhz hzhz mentioned this pull request May 13, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request May 14, 2024
Open
@akashmitra akashmitra mentioned this pull request May 15, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request May 22, 2024
Open
@maniator maniator mentioned this pull request May 22, 2024
Open
@akashmitra akashmitra mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillory @alitaheri @zannager