[TreeView] Fix Tree View inside shadow root crashes #36225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36225--material-ui.netlify.app/ Bundle size report |
oliviertassinari
added
the
component: tree view
Checks if the Node.getRootNode() function is available and use it in handleFocus. Fixes mui#36224
NoFr1ends
force-pushed
the
fix-treeitem-shadow-root
branch
from
63eb02d to
7b10b2c
Compare
ZeeshanTamboli
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Looks good. CodeSandbox after fix: https://codesandbox.io/s/mystifying-vaughan-70fx6p?file=/src/App.tsx
ZeeshanTamboli
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the Node.getRootNode() function is available and use it in handleFocus to prevent a crash when running inside a shadow root.
Fixes #36224