Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve visual look of loose lists #36190

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 14, 2023

This is a continuation of mui/mui-x#7899 to solve the problem differently. Instead of removing the use of loose lists for only tight lists, we can improve how loose lists are displayed to not feel broken. Each would have its own use cases:

a tight list for: bullet points
a loose list for: list paragraphs

The style of the docs currently didn't take into account that looses lists could exist. The UX (visual design aspect of it) feels broken on https://next.mui.com/x/react-date-pickers/base-concepts/#responsiveness

Tight list (no changes):

Screenshot 2023-02-16 at 19 55 18

Loose list before:

Screenshot 2023-02-16 at 19 52 51

Loose list after:

Screenshot 2023-02-16 at 19 52 31


I'm also using a loose list in https://deploy-preview-36190--material-ui.netlify.app/material-ui/react-radio-button/#accessibility now, as it seems to make sense in this context.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Feb 14, 2023
@oliviertassinari oliviertassinari force-pushed the improve-visual-design-of-loose-list branch from 6aa9da9 to 9b2b33e Compare February 14, 2023 23:01
@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Feb 14, 2023
@mui-bot
Copy link

mui-bot commented Feb 14, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 82a0bfd

@oliviertassinari oliviertassinari force-pushed the improve-visual-design-of-loose-list branch from 9b2b33e to 6e26634 Compare February 14, 2023 23:10
@oliviertassinari oliviertassinari force-pushed the improve-visual-design-of-loose-list branch from 6e26634 to 82a0bfd Compare February 14, 2023 23:22
@gerdadesign
Copy link
Member

Can you give more context and information around the original problem you were experiencing?

What are the before and after values for both loose and tight lists?

From the linked discussion, I would generally agree about the points made against 5px when on an 8px base, but without any descriptions here or in the other PR, I'm not sure what is to be reviewed.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 16, 2023

@gerdadesign I have updated the description, it should be clearer now.

@gerdadesign
Copy link
Member

Thank you! This description is a lot clearer now. 🙌
and the screenshot update on the loose lists nicely chunks the information in closer relation to one another

Is there any value in displaying the spacing between loose and tight list items differently?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 18, 2023

Is there any value in displaying the spacing between loose and tight list items differently?

@gerdadesign Right, it's partially for this question that I would like to get your input on this. So far, we have two opposite forces:

mui/mui-x#7899

Each list item is so far away with loose list, effectively at the same distance as in between two paragraphs: 16px, that it feels like they aren't part of a list anymore. Instead, we can use a tight list.

mui/mui-x#7899 (comment)

I added those line break (which are invalid) because 4px feels very compact to me.

@oliviertassinari oliviertassinari merged commit 2f2d266 into mui:master Mar 1, 2023
@oliviertassinari oliviertassinari deleted the improve-visual-design-of-loose-list branch March 1, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants