-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve visual look of loose lists #36190
[docs] Improve visual look of loose lists #36190
Conversation
6aa9da9
to
9b2b33e
Compare
Netlify deploy previewBundle size report |
9b2b33e
to
6e26634
Compare
6e26634
to
82a0bfd
Compare
Can you give more context and information around the original problem you were experiencing? What are the before and after values for both loose and tight lists? From the linked discussion, I would generally agree about the points made against 5px when on an 8px base, but without any descriptions here or in the other PR, I'm not sure what is to be reviewed. |
@gerdadesign I have updated the description, it should be clearer now. |
Thank you! This description is a lot clearer now. 🙌 Is there any value in displaying the spacing between loose and tight list items differently? |
@gerdadesign Right, it's partially for this question that I would like to get your input on this. So far, we have two opposite forces:
|
This is a continuation of mui/mui-x#7899 to solve the problem differently. Instead of removing the use of loose lists for only tight lists, we can improve how loose lists are displayed to not feel broken. Each would have its own use cases:
a tight list for: bullet points
a loose list for: list paragraphs
The style of the docs currently didn't take into account that looses lists could exist. The UX (visual design aspect of it) feels broken on https://next.mui.com/x/react-date-pickers/base-concepts/#responsiveness
Tight list (no changes):
Loose list before:
Loose list after:
I'm also using a loose list in https://deploy-preview-36190--material-ui.netlify.app/material-ui/react-radio-button/#accessibility now, as it seems to make sense in this context.