Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Update color for the docs full width example buttons #3601

Merged
merged 1 commit into from
Mar 8, 2016
Merged

[Dialog] Update color for the docs full width example buttons #3601

merged 1 commit into from
Mar 8, 2016

Conversation

nathanmarks
Copy link
Member

This one is for @oliviertassinari RE https://github.com/callemall/material-ui/pull/3590/files#r54964518

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari
Copy link
Member

Great 👍.
Could we do the same with the others exemples?

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Mar 5, 2016
@nathanmarks nathanmarks added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Mar 5, 2016
@nathanmarks
Copy link
Member Author

@oliviertassinari sure, I'll add it today.

@nathanmarks
Copy link
Member Author

"today" 😄

@nathanmarks nathanmarks added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Mar 8, 2016
oliviertassinari added a commit that referenced this pull request Mar 8, 2016
@oliviertassinari
Merge pull request #3601 from nathanmarks/docs-dialog-example
f4c33af 
[Dialog] Update color for the docs full width example buttons
@oliviertassinari oliviertassinari merged commit f4c33af into mui:master Mar 8, 2016
@oliviertassinari
Copy link
Member

@nathanmarks Thanks.

@oliviertassinari oliviertassinari mentioned this pull request Jun 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanmarks @oliviertassinari @mbrookes