Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Revise and expand the Joy UI "Badge" page #35199

Merged
merged 11 commits into from
Nov 28, 2022
Merged

[docs] Revise and expand the Joy UI "Badge" page #35199

merged 11 commits into from
Nov 28, 2022

Conversation

mapache-salvaje
Copy link
Contributor

Part of #33998.

This PR applies the style guide and latest component doc structure to the Joy UI Badge page. Notable changes include:

  • rearranging content and borrowing from MUI Base Badge content where they overlap
  • adding sections on Variants, Sizes, and Colors, along with simple demos showing all options for each
  • adding more details on Position and Inset implementation
  • adding component Anatomy

I also realized that I missed a callout on the Alert page that's repeated across these pages, so I went ahead and added it here.

@mui-bot
Copy link

mui-bot commented Nov 18, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35199--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against ef29a57

@mapache-salvaje mapache-salvaje added docs Improvements or additions to the documentation component: badge This is the name of the generic UI component, not the React module! design: joy This is about Joy Design, please involve a visual or UX designer in the process package: joy-ui Specific to @mui/joy and removed design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Nov 18, 2022
danilo-leal
danilo-leal approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this reads much better!

siriwatknp
siriwatknp approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Pushed a fix for the badgeContent playground showing "undefined".

Screen Shot 2565-11-21 at 15 30 19

@mapache-salvaje mapache-salvaje merged commit 1ac8b21 into mui:master Nov 28, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@mapache-salvaje @siriwatknp
[docs] Revise and expand the Joy UI "Badge" page (mui#35199)
71c23d7 
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
@mapache-salvaje mapache-salvaje mentioned this pull request Nov 29, 2022
Closed
61 tasks
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@mapache-salvaje @siriwatknp
[docs] Revise and expand the Joy UI "Badge" page (mui#35199)
b130ea0 
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
@mapache-salvaje mapache-salvaje deleted the joy-badge branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: badge This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mapache-salvaje @mui-bot @siriwatknp @danilo-leal