[eslint] Enforce operator-linebreak and no-multiple-empty-lines

[oliviertassinari]

No description provided.

[alitaheri]

Could we do this: [2, "after", { "overrides": { "?": "before", ":": "before"} }] to promote this style:

const foo = open
  ? 'open'
  : 'close';

this style is a lot cleaner for ternary, and a lot more readable when it's nested:

const foo = halfOpen
  ? 'halfOpen'
  : open
    ? 'open'
    : 'close';

[mbrookes]

Absolute not! 😆

[alitaheri]

😅

[oliviertassinari]

I would rather keep the style consistent and do no use the overrides option.
What do we do here 😁?

[alitaheri]

Carry on, nevermind my comment. As long as there is consistency I'm happy 😍 😍

[oliviertassinari]

Awesome and I'm already done 😁.

[alitaheri]

I think this is safe to merge. 👍 Let's do it 😎

[nathanmarks]

@alitaheri @oliviertassinari I think we should use this:

http://eslint.org/docs/rules/no-nested-ternary.html

😜

[mbrookes]

Holding for PR catch-up.

[oliviertassinari]

I think that it's safe to merge this PR. We haven't seen any conflict in a week, while merging many PRs.

[nathanmarks]

@oliviertassinari I'm going to re-run the build and will merge if all is 👍

[nathanmarks]

Ok, travis GUI output was screwed up at first (seemed cached from the initial build actually). I deleted my posts regarding it and the raw log. The errors are visible in the gui now.

@oliviertassinari can you fix these up quickly:

src/Stepper/HorizontalStep.jsx
  115:8  error  '?' should be placed at the end of the line  operator-linebreak
  116:8  error  ':' should be placed at the end of the line  operator-linebreak
  117:8  error  '?' should be placed at the end of the line  operator-linebreak
  118:8  error  ':' should be placed at the end of the line  operator-linebreak
src/Stepper/Stepper.jsx
  123:9  error  '&&' should be placed at the end of the line  operator-linebreak
src/Stepper/VerticalStep.jsx
  205:8  error  '?' should be placed at the end of the line  operator-linebreak
  206:8  error  ':' should be placed at the end of the line  operator-linebreak
  207:8  error  '?' should be placed at the end of the line  operator-linebreak
  208:8  error  ':' should be placed at the end of the line  operator-linebreak

[nathanmarks]

Is this a mistake?

We need tests to catch this sort of stuff so we can work with confidence. We shouldn't need to manually review typos like this 😢

[oliviertassinari]

😨

[nathanmarks]

😨