[docs] Move product versions to page context #35078
Conversation
Netlify deploy previewhttps://deploy-preview-35078--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
@m4theushw Thanks for pushing in this direction to make the docs infra more customizable. It looks good 👍.
Once this PR is merged I'll open follow-up PRs in Toolpad and MUI X to adapt docs/_app.js.
cc @bharatkashyap, Toolpad will also need to do the same. https://mui.com/toolpad/getting-started/overview/
Regarding the future direction. I think that we should work toward removing the duplication of the _app.js files. There is quite a lot of logic that should be owned by the docs infra over the MUI X / MUI Toolpad repositories.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
I'll merge next week after the release. |
|
|
||
| if (product === 'base') { | ||
| return { | ||
| name: 'MUI Base', |
There was a problem hiding this comment.
https://master--material-ui.netlify.app/base/getting-started/overview/
| name: 'MUI Base', | |
| name: 'Base UI', |
We changed the name since. This information was lost in the rebase of this PR. See the diff lower in the page.
@siriwatknp Do you want to push a quick fix?
There was a problem hiding this comment.
Fixed in ec3d7dd. I saw it again doing a demo with a person at React Summit. @michaldudak enjoy 😁
Related to #34296 (comment)
Currently, the information for all products (including versions) is inside https://github.com/mui/material-ui/blob/master/docs/src/modules/components/AppNavDrawer.js. This creates a problem where every time a new version for a product that has its own repo (e.g. MUI X or Toolpad) is going to be developed this file needs to updated to include it, consequently the new version only goes live in the next MUI Core release. This PR addresses this issue by moving the product information to the
PageContextallowing it to be injected by thedocs/_app.jsfile of the respective product repo.Once this PR is merged I'll open follow-up PRs in Toolpad and MUI X to adapt
docs/_app.js.