[docs] Fix reported SEO issues #33818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
commented
Aug 6, 2022
| @@ -11418,7 +11418,7 @@ _Apr 6, 2017_ | |||
|
|
|||
| We are continuing investing in the documentation and the test suite. | |||
|
|
|||
| Visual regression tests are now sent to [argos-ci](https://www.argos-ci.com/mui/material-ui). | |||
| Visual regression tests are now sent to [argos-ci](https://app.argos-ci.com/mui/material-ui/builds). | |||
| @@ -120,7 +120,7 @@ Visit our [`styled-engine` guide](https://mui.com/material-ui/guides/styled-engi | |||
|
|
|||
| <p align="center"> | |||
| <a href="https://octopus.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://i.ibb.co/w0HF0Nz/Logo-Blue-140px-rgb.png" alt="octopus" title="Repeatable, reliable deployments" loading="lazy" /></a> | |||
| <a href="https://www.doit-intl.com/flexsave/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://avatars3.githubusercontent.com/u/8424863?s=256" alt="doit-intl" title="Management Platform for Google Cloud and AWS" loading="lazy" /></a> | |||
| <a href="https://www.doit-intl.com/flexsave/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://avatars.githubusercontent.com/u/8424863?s=256" alt="doit-intl" title="Management Platform for Google Cloud and AWS" loading="lazy" /></a> | |||
There was a problem hiding this comment.
Hit the main subdomain, let the infrastructure load balance behind the scene
| <Typography level="h1" fontSize="xl2" mb={2} textColor="text.secondary"> | ||
| <Typography | ||
| level="h1" | ||
| component="div" |
There was a problem hiding this comment.
| @@ -86,7 +86,7 @@ The `Typography` component has access to the typographic level scale defined in | |||
| Use the `level` prop to control the scale value. | |||
|
|
|||
| :::info | |||
| **Keep in mind:** each level renders a specific HTML tag (e.g. "h1" renders as an `<h2>` element, "body1" renders as a `<p>`, etc.) | |||
| **Keep in mind:** each level renders a specific HTML tag (e.g. "h1" renders as an `<h1>` element, "body1" renders as a `<p>`, etc.) | |||
There was a problem hiding this comment.
I guess it was a typo, cc @siriwatknp
Comment on lines
+1
to
+5
| --- | ||
| title: Overview | ||
| --- | ||
|
|
||
| # Joy UI - Overview |
There was a problem hiding this comment.
| @@ -5,29 +5,29 @@ import Typography from '@mui/material/Typography'; | |||
| export default function Types() { | |||
| return ( | |||
| <Box sx={{ width: '100%', maxWidth: 500 }}> | |||
| <Typography variant="h1" component="div" gutterBottom> | |||
| <Typography variant="h1" gutterBottom> | |||
There was a problem hiding this comment.
Replicate the tradeoff taken in https://mui.com/joy-ui/react-typography/#levels there are no reasons to have a different tradeoff AFAIK, I'm using Joy UI's tradeoff for Material UI, sounds like a better DX. cc @siriwatknp
| <a href="https://online-aussie-casino.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/aussiecasinohex/923df37/logo/192.png" alt="online-aussie-casino.com" title="Aussie Gambling Guide" loading="lazy" /></a> | ||
| <a href="https://sumatosoft.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/sumatosoft_company/0b78570/avatar/192.png" alt="sumatosoft.com" title="We help companies to digitalize their businesses" loading="lazy" /></a> | ||
| <a href="https://megafamous.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://p18.zdusercontent.com/attachment/9422375/Rullx0rw9lUGKuyKOy4VQ9Zxq?size=192" alt="megafamous.com" title="The best place to buy Instagram followers & likes." loading="lazy" /></a> | ||
| <a href="https://megafamous.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://mui.com/static/sponsors/megafamous.png" alt="megafamous.com" title="The best place to buy Instagram followers & likes." loading="lazy" /></a> |
There was a problem hiding this comment.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.ahrefs.com/site-audit/3524616/25/overview