-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Adding missing accessibility labels #33782
[docs] Adding missing accessibility labels #33782
Conversation
Can you please review this one ? Thanks |
@PunitSoniME please share on the issue a description of what the problem really as. Also, can you provide some link to wai aria docs with more explanation for the changes related in the PR? Thanks! |
docs/data/material/components/button-group/DisableElevation.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/components/toggle-button/ColorToggleButton.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/components/floating-action-button/FloatingActionButtonExtendedSize.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for the patience :)
Fixes #33781
Test changes here