[Autocomplete] differentiate between hover and keyboard highlight states

[cjtroiano]

I would have liked to use css for the mouse "cursor", but I wasn't able to test it properly.
If thats preferred, then I could use some help on detecting that in a test.

fix #23916

• [ x] I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Details of bundle changes

Generated by 🚫 dangerJS against c819bc2

[michaldudak]

Hi @cjtroiano. Sorry it took us so long to get to review your PR.
Regarding the implementation - I don't think having .Mui-focused and .Mui-focusVisible on different elements is the best solution. If we're going with the pattern used by Chrome's omnibox, I think that styling elements on hover with CSS should be enough.
What I'm worried about, though, is that it'll change the behavior in existing applications, and there may be developers relying on the current behavior.

We may need to wait until v6 before we fix it this way.

Two things that come to my mind that we can do today:

1. put this behavior behind a prop (disableHighlightOnHover) that's false by default
2. expose the highlightedItem as a controlled prop. This way, it will become possible for developers to decide when a highlight should be changed

cc @mnajdova for thoughts

[mnajdova]

1. put this behavior behind a prop (disableHighlightOnHover) that's false by default

Agree, we should do this as part of this PR, in v6 we could make this default behavior and drop the prop.

2. expose the highlightedItem as a controlled prop. This way, it will become possible for developers to decide when a highlight should be changed

Agree, we can anyway do this regardless of the previous implementation. Having a controlled prop for it sounds reasonable.

[einvalentin]

Hey! Thanks @mnajdova - quick question - is there an issue that I could track when this is done? :) Right now it causes a small regression for our project. No show stopper, but it would be good to be able to see when to update the library 👍🏽

[mnajdova]

@einvalentin I can prioritize reviewing it if we have a contribution from the community, but I have no bandwidth to do it myself.