Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Add flag to switch negative margin approach in Grid #33484

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jul 12, 2022

Preview: https://deploy-preview-33484--material-ui.netlify.app/system/react-grid/#prevent-scrollbar

Motivation

Aim to fix #7466 by opting in. When the flag is true, the negative margin is applied to top and left sides of the grid (similar to the current Grid v5)


@siriwatknp siriwatknp added component: Grid The React component. package: system Specific to @mui/system labels Jul 12, 2022
@mui-bot
Copy link

mui-bot commented Jul 12, 2022

Details of bundle changes

@material-ui/core: parsed: +0.14% , gzip: +0.14%
@material-ui/system: parsed: +1.09% , gzip: +0.70%
@mui/joy: parsed: +0.38% , gzip: +0.32%

Generated by 🚫 dangerJS against 2b9f954

@siriwatknp siriwatknp requested a review from mnajdova July 13, 2022 07:44
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, people will be happy with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Grid] Extra width of container & scrollbar
3 participants