Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styled-engine] Add missing type dependency on csstype #33310

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jun 27, 2022

The TypeScript declaration files for @mui/styled-engine import from csstype, so csstype should be added as a dependency of @mui/styled-engine.

TS2307: Cannot find module 'csstype' or its corresponding type declarations.
  > 1 | import * as CSS from 'csstype';
      |                      ^^^^^^^^^
    2 | import { StyledComponent, StyledOptions } from '@emotion/styled';
    3 | import { PropsOf } from '@emotion/react';
    4 |

@mui-bot
Copy link

mui-bot commented Jun 27, 2022

No bundle size changes

Generated by 🚫 dangerJS against 278ed29

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaldudak michaldudak added bug 🐛 Something doesn't work package: styled-engine Specific to @mui/styled-engine labels Jul 1, 2022
@michaldudak michaldudak changed the title Add missing type dependency on csstype [styled-engine] Add missing type dependency on csstype Jul 1, 2022
@michaldudak michaldudak merged commit f2d8c6a into mui:master Jul 1, 2022
@Methuselah96 Methuselah96 deleted the add-csstype-dep branch July 1, 2022 13:27
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: styled-engine Specific to @mui/styled-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants