Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Extend componentsProps to include popper and popupIndicator slots #33283

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[Autocomplete] Extend componentsProps to include popper and popupIndicator slots #33283

merged 1 commit into from
Jun 30, 2022

Conversation

jake-collibra
Copy link
Contributor

@jake-collibra jake-collibra commented Jun 24, 2022 •
edited by ZeeshanTamboli
Loading

Closes #33233
Closes #33234

@mui-bot
Copy link

mui-bot commented Jun 24, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 70b4854

@jake-collibra jake-collibra force-pushed the extend-autocomplete-componentProps branch 3 times, most recently from f70aa5c to 5b2fb07 Compare June 24, 2022 20:52
@ZeeshanTamboli ZeeshanTamboli added component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request labels Jun 29, 2022
ZeeshanTamboli
ZeeshanTamboli reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍. Thanks for adding the componentsProps.clearIndicator tests as well.

Would you also be willing to add TypeScript test here?

@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] Extend componentsProps to include popper and popupIndicator [Autocomplete] Extend componentsProps to include popper and popupIndicator slots Jun 29, 2022
@jake-collibra jake-collibra force-pushed the extend-autocomplete-componentProps branch from 5b2fb07 to 70b4854 Compare June 29, 2022 15:46
@jake-collibra
Copy link
Contributor Author

@ZeeshanTamboli I just added the missing slots to the highlighted function - that's all that needs to happen, right?

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli I just added the missing slots to the highlighted function - that's all that needs to happen, right?

Yes, thanks.

ZeeshanTamboli
ZeeshanTamboli approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request on Material UI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 931facf into mui:master Jun 30, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@jake-collibra
[Autocomplete] Extend componentsProps to include popper and `popu…
0007c68 
…pIndicator` slots (mui#33283)

[Autocomplete] Extend `componentsProps` to include `popper` and `popupIndicator` slots (mui#33233, mui#33234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jake-collibra @mui-bot @ZeeshanTamboli