Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add radio button documentation #33254

Merged
merged 11 commits into from
Jul 1, 2022
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 22, 2022

@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Jun 22, 2022
@mui-bot
Copy link

mui-bot commented Jun 22, 2022

Details of bundle changes

@mui/joy: parsed: +0.19% , gzip: +0.19%

Generated by 🚫 dangerJS against 1313a6e

@siriwatknp siriwatknp requested a review from danilo-leal June 23, 2022 10:39
@siriwatknp siriwatknp marked this pull request as ready for review June 23, 2022 10:39
@siriwatknp
Copy link
Member Author

@danilo-leal I moved RadioGroup and Controlled demos up because they are more common than Position.

@danilo-leal
Copy link
Contributor

I figured that but I'd say it's good to follow the flow of simplecomplex on the documentation. As the RadioGroup is already an aggregator component for more complex layouts, position made sense to come in first. What do you think?

@siriwatknp
Copy link
Member Author

siriwatknp commented Jun 24, 2022

I figured that but I'd say it's good to follow the flow of simplecomplex on the documentation. As the RadioGroup is already an aggregator component for more complex layouts, position made sense to come in first. What do you think?

I agree completely with simplecomplex. That's why I move the RadioGroup up because I'd say that it is the most simple one (it is more common to use RadioGroup rather than a single Radio).

The layouts and position come later (not every app needs them).

@danilo-leal
Copy link
Contributor

That makes sense but then it's a different rationale, isn't it?
Simple to complex as opposed to more frequently used to less frequently used.
I'd still follow the first one!

@danilo-leal danilo-leal changed the title [Joy] Add radio button documentation page [Joy] Add radio button documentation Jun 28, 2022
@siriwatknp
Copy link
Member Author

That makes sense but then it's a different rationale, isn't it?

Simple to complex as opposed to more frequently used to less frequently used.

I'd still follow the first one!

That's true. I will revert the change then.

@danilo-leal danilo-leal merged commit 967987e into mui:master Jul 1, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants