[docs] Clarify difference in startup times between named and default imports in minimizing-bundle-size.md #33109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Jun 22, 2022
docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
…ndle-size.md Co-authored-by: Marija Najdova <mnajdova@gmail.com>
|
Please run |
|
Added lint, thanks for the reminder @michaldudak Also, can take or leave this wording suggestion, it is certainly more verbose but I thought just spelling it out could help. |
michaldudak
reviewed
Jul 11, 2022
Comment on lines
29
to
31
| Startup times can be approximately 6x slower with named imports than without e.g. | ||
|
|
||
| In some cases |
There was a problem hiding this comment.
I'd remove the "in some cases". We already say that they can be slower.
Suggested change
| Startup times can be approximately 6x slower with named imports than without e.g. | |
| In some cases | |
| Startup times can be approximately 6x slower with named imports than without e.g.: | |
|
@samuelsycamore would you mind taking a quick look? |
docs/data/material/guides/minimizing-bundle-size/minimizing-bundle-size.md
Outdated
Show resolved
Hide resolved
…ndle-size.md Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
mapache-salvaje
changed the title
mapache-salvaje
changed the title
mapache-salvaje
added
docs
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
…imports in minimizing-bundle-size.md (mui#33109) Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I was trying to work out a bug where I am seeing a bunch of icons in my built version. I am not sure why but while trying to debug I came across this part of the documentation. I added some changes in this PR to try to clarify this section in detail cause it's a little hard to interpret. Let me know if that helps!