[docs] Fix Link typings in the react-router example #32308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
changed the title
|
@danilo-leal - it is green now - yeah |
mnajdova
reviewed
May 18, 2022
| @@ -16,9 +16,15 @@ You can also make a button perform navigation actions. You can also make a butto | |||
|
|
|||
| In real-life applications, using a native `<a>` element is rarely enough. element is rarely enough. You can improve the user experience by using an enhanced Link component systematically. The theme of Material UI allows configuring this component once. For instance, with react-router: The theme of MUI allows configuring this component once. For instance, with react-router: | |||
|
|
|||
| ```jsx | |||
| ```tsx | |||
There was a problem hiding this comment.
We are not manually changing the translation files. Please revert the changes in the routing-zh.md and routing-pt.md and we should be good to merge :)
There was a problem hiding this comment.
@mnajdova addressed
|
Could you please also update the LinkRouterWithTheme demo to be consistent with the example (type the forwardRef argument)? |
|
@michaldudak - updated (I erased my previous comment - I misread your comment - meh 😿 ) |
michaldudak
approved these changes
Jul 4, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32306