[docs] Base Menu style revisions and final review #32097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapache-salvaje
commented
Apr 1, 2022
20 tasks
mapache-salvaje
added
docs
michaldudak
reviewed
Apr 4, 2022
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
|
I think this one is ready to go now! 👍 |
danilo-leal
approved these changes
Apr 4, 2022
mnajdova
reviewed
Apr 5, 2022
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the style guide to the Base Menu document. For this piece, the changes mostly amount to placing
MenuUnstyledandMenuItemUnstyledinside back ticks.This piece also answered the question I posed in #32095 about naming the hooks in the title—and the answer is no! The title of this one would be way too dense if I named both hooks there. I will update the others I've reviewed so far to reflect this.
Preview - https://deploy-preview-32097--material-ui.netlify.app/base/react-menu/