[docs] Simplify customization examples in ButtonUnstyled demos #32092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: button
There was a problem hiding this comment.
Great, thanks for this simplification 👍. I think that it's much better for the design systems teams to use base. I would argue a best practice (with the previous pattern a footgun)
I would expect that design system teams will take our MUI Base demos, change the CSS, and expose this to their company's developer (A) as a package. After this change, (A) can more easily add another layer of customization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ButtonUnstyled demos show the simpler
styled(ButtonUnstyled)approach where possible.It reduced the number of rendered components and allow additional customization (like rendering an
ainstead of abutton).https://deploy-preview-32092--material-ui.netlify.app/base/react-button/