Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add small size Select demo #32060

Merged
merged 3 commits into from
Mar 30, 2022
Merged

[docs] Add small size Select demo #32060

merged 3 commits into from
Mar 30, 2022

Conversation

ivan-ngchakming
Copy link
Contributor

@ivan-ngchakming ivan-ngchakming commented Mar 30, 2022 •
edited
Loading

Added demo in documentation to showcase demo of a select component with size='small' prop.

image

Preview:
https://deploy-preview-32060--material-ui.netlify.app/components/selects/#small-size

closes #31348

@mui-bot
Copy link

mui-bot commented Mar 30, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 2c8620c

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: select This is the name of the generic UI component, not the React module! labels Mar 30, 2022
@danilo-leal danilo-leal changed the title [docs] Added select size small demo [docs] Add small size Select demo Mar 30, 2022
danilo-leal
danilo-leal reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for contributing! I believe you should also add a SelectSmall.tsx file as well — every demo has one in js and ts.

danilo-leal
danilo-leal approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me! Thanks for contributing =)

@danilo-leal danilo-leal merged commit de59cb0 into mui:master Mar 30, 2022
@ivan-ngchakming ivan-ngchakming deleted the docs/select-small branch March 30, 2022 15:17
@ManitaJ123
Copy link

Added demo in documentation to showcase demo of a select component with size='small' prop.

image

Preview: https://deploy-preview-32060--material-ui.netlify.app/components/selects/#small-size

closes #31348

Thank you. This will resolve our issue. Really appreciate it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] Misaligned placeholder when size=small
4 participants
@ivan-ngchakming @mui-bot @ManitaJ123 @danilo-leal