Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add page for CSS variables support in @mui/material #32050

Merged
merged 64 commits into from
Apr 6, 2022
Merged

[docs] Add page for CSS variables support in @mui/material #32050

merged 64 commits into from
Apr 6, 2022

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 30, 2022 •
edited
Loading

Preview: https://deploy-preview-32050--material-ui.netlify.app/experimental-api/css-variables/

I've also moved the "ClassName Generator" page to this new Experimental APIs section in the sidebar

@mui-bot
Copy link

mui-bot commented Mar 30, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 3debebe

@mnajdova mnajdova marked this pull request as ready for review March 30, 2022 10:09
@mnajdova mnajdova added the docs Improvements or additions to the documentation label Mar 30, 2022
mnajdova and others added 6 commits March 30, 2022 21:15
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
62aa11a 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
5e5d42f 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
a289600 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
6ad517f 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
9c2cc01 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
fbc6587 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
siriwatknp and others added 3 commits April 5, 2022 08:06
@siriwatknp @mapache-salvaje
Apply suggestions from code review
f03aa35 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@siriwatknp
reorder usage
863b55f
@siriwatknp
remove color scheme for simplicity
0e7c1bc
@siriwatknp
Copy link
Member

siriwatknp commented Apr 5, 2022 •
edited
Loading

What would be a good hiearachy for the content under Usage? I feel like we could a bit different like it is right now, maybe:

  • Customizing the components
  • Customizing the theme
  • Toggle between light and dark
  • Server-side rendering
  • Next.js
  • Gatsby

Updated! I removed some references about color schemes to make it simplest as much as possible. I think we can add more explanation about the color schemes in a separate PR.

@mnajdova
Copy link
Member Author

mnajdova commented Apr 5, 2022

I think we can add more explanation about the color schemes in a separate PR.

Makes sense.

siriwatknp
siriwatknp approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nicely done.

mnajdova and others added 5 commits April 5, 2022 15:23
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
6725734 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
90aa8a0 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
5cdc6f1 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
3647b66 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
8b69612 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova and others added 3 commits April 5, 2022 15:32
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
b363081 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova @danilo-leal
Update docs/data/material/experimental-api/css-variables/css-variable…
f1a571f 
…s.md

Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
@mnajdova
Ask feedback in the Note
c43d6e9
mapache-salvaje
mapache-salvaje reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just teeny tiny final polishing stuff here. 99% ready to go if you ask me!

docs/data/material/experimental-api/css-variables/css-variables.md Outdated Show resolved Hide resolved
docs/data/material/experimental-api/css-variables/css-variables.md Outdated Show resolved Hide resolved
docs/data/material/experimental-api/css-variables/css-variables.md Outdated Show resolved Hide resolved
docs/data/material/experimental-api/css-variables/css-variables.md Outdated Show resolved Hide resolved
danilo-leal
danilo-leal approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work everybody :)

@siriwatknp @mapache-salvaje
Apply suggestions from code review
3debebe 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@siriwatknp siriwatknp merged commit 4678d1e into mui:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapache-salvaje mapache-salvaje mapache-salvaje left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnajdova @mui-bot @siriwatknp @danilo-leal @mapache-salvaje