Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve a11y on the split button demo #31969

Merged
merged 1 commit into from
Mar 28, 2022
Merged

[docs] Improve a11y on the split button demo #31969

merged 1 commit into from
Mar 28, 2022

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 24, 2022 •
edited by danilo-leal
Loading

@mui-bot
Copy link

mui-bot commented Mar 24, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 1bc3b8b

@mnajdova mnajdova changed the title [docs] Improve a11y on the SplitButton demo [docs] Improve a11y on the split button demo Mar 24, 2022
@mnajdova mnajdova added docs Improvements or additions to the documentation accessibility a11y labels Mar 24, 2022
@danilo-leal danilo-leal added the component: button This is the name of the generic UI component, not the React module! label Mar 24, 2022
@mnajdova mnajdova requested a review from a team March 25, 2022 08:30
@mnajdova
Copy link
Member Author

mnajdova commented Mar 25, 2022 •
edited
Loading

cc @brucelawson, could you validate the updated demo?

siriwatknp
siriwatknp approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mnajdova mnajdova merged commit 1069090 into mui:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ButtonGroup] Split button requires an extra tab to get focus into the drop-down
4 participants
@mnajdova @mui-bot @siriwatknp @danilo-leal