Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Solve duplication of content #31917

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 20, 2022

All of the https://mui.com/material-ui/ pages are indexed on Google, for instance: https://www.google.com/search?q=%22https%3A%2F%2Fmui.com%2Fmaterial-ui%2Freact-alert%2F%22. I could find one path that leads to this outcome

  1. https://mui.com/components/menus/#unstyled
  2. https://mui.com/base/react-menu/
  3. https://mui.com/base/api/menu-unstyled/
  4. https://mui.com/material-ui/guides/minimizing-bundle-size/
  5. https://mui.com/material-ui/react-alert/ 🎰

This leads to duplication of content, which we shouldn't let fly.

I have noticed the problem in https://app.ahrefs.com/site-audit/2944028/37/issues. We reach the limit I set on the number of internal pages (2,000). Usually, we have ~1,352 internal pages that are crawlable.

Screenshot 2022-03-20 at 14 15 50

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 20, 2022
@oliviertassinari oliviertassinari force-pushed the fix-duplication-of-content branch from 18595ee to 88583d5 Compare March 20, 2022 13:13
@mui-bot
Copy link

mui-bot commented Mar 20, 2022

No bundle size changes

Generated by 🚫 dangerJS against c18b20f

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feature toggle condition so that I don't forget when I enable the redirects next week.

@mnajdova mnajdova merged commit f231b79 into mui:master Mar 21, 2022
@oliviertassinari oliviertassinari deleted the fix-duplication-of-content branch March 22, 2022 01:01
@oliviertassinari
Copy link
Member Author

Added feature toggle condition so that I don't forget when I enable the redirects next week.

Perfect, I used the same comment "TODO remove post migration" as in #31916, but the const is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants