Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Should not crash when an empty array is passed with multiple enabled #29957

Merged
merged 8 commits into from
Dec 6, 2021
Merged

[Select] Should not crash when an empty array is passed with multiple enabled #29957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
872bd6b
Provide fallback for reduce
Domino987 Nov 29, 2021
a6844d5
fix styling
Domino987 Dec 1, 2021
65a856f
Reduce to simple join
Domino987 Dec 1, 2021
606f6b5
Fix for empty input and objects
Domino987 Dec 1, 2021
1533a74
short circuit for empty multiple value
Domino987 Dec 1, 2021
b364d21
Add test for multiple with empty value
Domino987 Dec 1, 2021
f4546fb
Override for palceholder data
Domino987 Dec 2, 2021
d5d99df
conceptional cleanup
Domino987 Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/mui-material/src/Select/Select.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,20 @@ describe('<Select />', () => {
expect(getByRole('button')).to.have.text('Ten, Twenty, Thirty');
});

it('should not throw an error for an empty multiple list', () => {
const { getByRole } = render(
<Select multiple value={[]}>
<MenuItem value={10}>Ten</MenuItem>
<MenuItem value={20}>
<strong>Twenty</strong>
</MenuItem>
<MenuItem value={30}>Thirty</MenuItem>
</Select>,
);
// A zero-width string is added for empty values
expect(getByRole('button')).to.have.text('\u200B');
});

it('selects value based on their stringified equality when theyre not objects', () => {
const { getAllByRole } = render(
<Select multiple open value={['10', '20']}>
Expand Down
6 changes: 5 additions & 1 deletion packages/mui-material/src/Select/SelectInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,11 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {

if (computeDisplay) {
if (multiple) {
display = displayMultiple.reduce((prev, curr) => [prev, ', ', curr]);
if (value.length === 0) {
display = '';
} else {
display = displayMultiple.reduce((prev, curr) => [prev, ', ', curr]);
}
} else {
display = displaySingle;
}
Expand Down