[StaticDatePicker] Add className and slot to PickerStaticWrapper

[kkorach]

• I have followed (at least) the PR section of the contributing guide.

This PR adds the className MuiStaticWrapper and slot root to the StaticWrapper component used by the StaticDatePicker. The name does seem a bit generic, but the StaticWrapper is only used by the DatePicker components. I couldn't find any other uses of the name StaticWrapper.

[mui-pr-bot]

Details of bundle changes

@material-ui/lab: parsed: +0.09% , gzip: +0.07%

Generated by 🚫 dangerJS against cdcb212

[kkorach]

Cool, I'll make the change and push it back up today

[mnajdova]

Let's add a test to confirm that this works. Apart from that looks good 👍

[mnajdova]

We need to also update the components.d.ts and overrides.d.ts in https://github.com/mui-org/material-ui/tree/master/packages/mui-lab/src/themeAugmentation to make sure we won't have TypeScript issues.

[kkorach]

@mnajdova Since I've switched the className to be more specific, I get this error: error Expected name to be 'MuiStaticWrapper' but instead got 'MuiPickerStaticWrapper' material-ui/mui-name-matches-component-name

If this is a firm rule, then it would have to be named MuiStaticWrapper. Are there other cases where this rule is disabled?

Also, for testing. What in particular are you thinking we should test. It looks like describeConformance is what is needed? The StaticDataPicker doesn't have one, but StaticDateRangePicker does.

[mnajdova]

@mnajdova Since I've switched the className to be more specific, I get this error: error Expected name to be 'MuiStaticWrapper' but instead got 'MuiPickerStaticWrapper' material-ui/mui-name-matches-component-name

Right.. I would say we need to rename this component, it is an internal component shouldn't affect developers. Would you be willing to do this? It would wider the scope fo the PR. @michaldudak what do you think about this rename?

If this is a firm rule, then it would have to be named MuiStaticWrapper. Are there other cases where this rule is disabled?

No, we keep the component names consistent with the keys, as I mentioned above in my opinion the component name is too generic in this case.

Also, for testing. What in particular are you thinking we should test. It looks like describeConformance is what is needed? The StaticDataPicker doesn't have one, but StaticDateRangePicker does.

Ensuring that describeConfromance pass would be great 👌

[michaldudak]

in my opinion the component name is too generic in this case.

100% agree. It may be internal but internal components are also maintained by human beings that sometimes may need some assistance in figuring out what the component is for 😉. Let's rename the component.

[mnajdova]

Perfect! Thanks for the work and patience :)

[kkorach]

@mnajdova What's the next step?

[mnajdova]

@mnajdova What's the next step?

I've merged latest master, let's wait for the green build and merge :)

[mnajdova]

Great job @kkorach thanks for the contribution!