-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix broken link & update MUI packages explanation #29583
Conversation
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styled-engine
is the (unfortunate) name for the style library wrapper / adapter package, but there's no such thing as a "styled-engine" as a generic term. Should we stick to something like "style library adapter" when not referring to the styled-engine
package specifically? It's quite confusing otherwise.
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt <github@nospam.33m.co>
"style library adapter" sounds good to me. |
@mbrookes We can agree not to agree (an nth time). When I read "styled-engine-sc" I think: "oh, styled-components is the engine that powers the
Is this capitalization correct? I'm used to seeing TL;DR with uppercases because it's an acyronms.
This is not how we have been treating them so far. The private modules in utils are prefixed with core -> base
This can be controversial. Yarn 2 doesn't even allow implicit transitive dependency. There is eslint rule that warns against them: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-extraneous-dependencies.md. I think that it would be wiser not to say anything. |
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
docs/src/pages/guides/understand-mui-packages/understand-mui-packages.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…docs/improve-packages
changed to TL;DR
content removed.
image updated.
content removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are we sure about the size of the images? For example, /static/images/packages/mui-packages.png displays blurry on my x2 screen. Its displayed size is 448px so I would assume that we can use an image with an intrinsic size of 896px (x2). It's currently 1381px. Same for docs/public/static/images/packages/mui-system.png. It definitely makes a visible difference in my screen display environment, but I don't know if it would also help developers with an x1 display. BTW, I have purchased the latest MackBook Pro, only for the XDR display, so I can be pickier in the future with visual aesthetics 👼. Looks good otherwise |
The size looks correct to me, 1381px is more than 896px so wouldn't it give a similar result. I can open a fix later. |
👀 👀 👀 fancy! |
@siriwatknp Yeah, I don't know if this only helps people like me on macOS hardware or Windows developers with regular screens too. In the case of Apple, the CSS pixel is 448, so it uses 896 real pixels. Now, if the image is also 896 pixels, then the OS doesn't need to resize it 👌. With a larger image size, the OS has to resize it, the text loses its crispness, it becomes fuzzy, harder to read. At the end of the day, does it make a difference? For macOS users, with x2 resolution, I can notice for sure, it looks easier to read. For Windows users, maybe it doesn't matter; I have no idea, I suspect it doesn't matter, unless 2px -> 1px yields better resize results than 2.3px -> 1px for the algorithms used. I could test that with my girlfriend's laptop. |
close #29493
Preview: https://deploy-preview-29583--material-ui.netlify.app/guides/understand-mui-packages/#main-content