[Docs] Divider, DropDownMenu, FlatButton, FloatingActionButton, FontIcon - Add title & description to examples #2955
Conversation
mbrookes
changed the title
|
Please check FontIcon in particular, as I wasn't totally sure of the reason the simple example only required a classname, while the other has the icon name as a child - or whether calling these Custom and Public was appropriate. |
| const descriptions = { | ||
| simple: '`FlatButton` with default color, `primary`, `secondary` and and `disabled` props applied.', | ||
| complex: 'The first example uses an `input` as a child component, ' + | ||
| 'the next has next has an [SVG Icon](http://localhost:3000/#/components/svg-icon), with the label positioned after.' + |
There was a problem hiding this comment.
We should remove http://localhost:3000
That's a good point. Those classnames are declared outside of the examples, they are private to the documentation. I have seen many issues related to this. |
mbrookes
changed the title
| simple: '`FlatButton` with default color, `primary`, `secondary` and and `disabled` props applied.', | ||
| complex: 'The first example uses an `input` as a child component, ' + | ||
| 'the next has next has an [SVG Icon](/#/components/svg-icon), with the label positioned after. ' + | ||
| 'The final example uses a [FontIcon](/#/components/font-icon, and is wrapped in an anchor tag.', |
|
Fixed up and squashed onto the FlatButton commit. |
[Docs] Divider, DropDownMenu, FlatButton, FloatingActionButton, FontIcon - Add title & description to examples
|
@mbrookes Thanks |
For #2927.