[docs] Do not repeat language snippet in url in Algolia search #29483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not solving the root issue. Now, when you use Enter to validate a result, you lose the language prefix. Actually, something else is wrong, keyboard interactions do a hard navigation, it's wrong, it should be client-side navigation. |
oliviertassinari
added
bug 🐛
|
@oliviertassinari I addressed your points. It's working on my local server. Let me know. |
|
I noticed one issue when using the Enter key.
I have a quick fix coming next. |
siriwatknp
reviewed
Nov 11, 2021
| @@ -277,7 +277,7 @@ function AppFrame(props) { | |||
| {LANGUAGES_LABEL.map((language) => ( | |||
| <MenuItem | |||
| component="a" | |||
| data-no-link="true" | |||
| data-no-markdown-link="true" | |||
There was a problem hiding this comment.
What is this for? No objection, just want to know what it does.
There was a problem hiding this comment.
MarkdownLinks.js tries to handle all the <a> clicks. This was done to have smooth routing navigation on the markdown. data-no-markdown-link opt-out from this behavior.
siriwatknp
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29332
Closes #29461
Problem:
https://mui.com/zh/zh/components/buttons/#main-contentmui.comalready changes tomui.com/${language}if language other than English is set.(1) Go to https://mui.com/getting-started/usage/
(2) Change language setting to Portuguese
(3) Open algolia searchbox and enter "mig"
(4) Click the first link
(4) You will be directed to
https://mui.com/pt/pt/guides/migration-v4/#main-contentSolution:
Preview: https://deploy-preview-29483--material-ui.netlify.app/