[docs] Fix layout shift when scrolling #29436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
I still see a layout shift (capture from the preview link). Screen.Recording.2564-11-01.at.17.48.08.mov |
|
@siriwatknp Oh yeah, I didn't solve the layout shift of the toc on loading, only on scrolling. I assume it will require a different approach. I'm less worried about on loading. My main concern with the one on scrolling is that I can't look back and forth between the content of the page and the toc when I scroll, the position of the toc is not stable, it disorients me. |
siriwatknp
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have first noticed the issue on X: https://deploy-preview-3006--material-ui-x.netlify.app/components/data-grid/editing/#server-side-validation with @m4theushw's PR. But it can also be reproduced on the Core. As you scroll, the font weight of the highlighted item increases, making it sometimes wrap, and shifting the rest of the table of content.
https://mui.com/components/links/#security
Compare with how it feels smoother on https://stripe.com/docs/terminal/overview. I went on reproducing the same behavior: no change of font-weight. I believe there is already enough contrast, more is taking the risk to catch the attention of the user away from what matters: the body of the page.
Preview: https://deploy-preview-29436--material-ui.netlify.app/components/links/