Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputBase] Do not repeat the same classname #29353

Merged
merged 2 commits into from
Oct 28, 2021
Merged

[InputBase] Do not repeat the same classname #29353

merged 2 commits into from
Oct 28, 2021

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Oct 28, 2021 •
edited
Loading

Closes #29338

Problem:

  • with inputProps={{ className: browser-default }} on a TextField component, input element has two of the same classname: browser-default.

Before:

After:

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 28, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against be4ac50

@hbjORbj hbjORbj requested a review from mnajdova October 28, 2021 11:49
@hbjORbj hbjORbj mentioned this pull request Oct 28, 2021
Closed
2 tasks
mnajdova
mnajdova approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mnajdova mnajdova merged commit 904f182 into mui:master Oct 28, 2021
@oliviertassinari oliviertassinari mentioned this pull request Oct 28, 2021
Merged
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Oct 28, 2021
@oliviertassinari
Copy link
Member

I have added the relevant labels on the PR, so we can, later on, create analytics on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] ClassName passed in inputProps is added twice to input element
4 participants
@hbjORbj @mui-pr-bot @oliviertassinari @mnajdova